FIT: new feature("--file-for") for digit2raw#6935
Conversation
afurs
requested review from
AllaMaevskaya,
jotwinow and
mslupeck
as code owners
|
@shahor02 , @davidrohr as you requested, new "--file-for" feature is prepared for FIT's digit2raw. FLP name could be defined via --flp-name(by default "alio2-cr1-flp180"). Because 2 new FLPs are not installed yet for FIT(3 in total, 1 for each subdetector) and we don't know new flp names, I putted "-fv0"/"-fdd" suffix in default flp name. And "--file-per-link" is removed |
davidrohr
left a comment
davidrohr
left a comment
There was a problem hiding this comment.
Looks good, but you will also need to change the option in O2/prodtests/full-system-test/dpl-workflow.sh, otherwise the FullCI will fail
|
@davidrohr but what exactly should I change in |
|
@afurs : Oh, sorry, I meant `prodtests/full_system_test.sh? |
|
@davidrohr , ok, it's done for |
no, everything is fine now (the other file is currently not used and not checked in the CI, so would not have broken the CI) |
| // add_option("input-file,i", bpo::value<std::string>()->default_value(o2::base::NameConf::getDigitsFileName(o2::detectors::DetID::FT0)),"input FT0 digits file"); // why not used? | ||
| add_option("input-file,i", bpo::value<std::string>()->default_value("ft0digits.root"), "input FT0 digits file"); | ||
| add_option("file-per-link,l", bpo::value<bool>()->default_value(false)->implicit_value(true), "create output file per CRU (default: per layer)"); | ||
| add_option("flp-name", bpo::value<std::string>()->default_value("alio2-cr1-flp180"), "single file per: all,flp,cru,link"); |
There was a problem hiding this comment.
Actually, the comment for this option seems to be wrong, I guess copy&paste error.
There was a problem hiding this comment.
yes, sorry, i can change it in next PR(in few hours)
There was a problem hiding this comment.
oh, I meant after merging this one :) It will be not in few hours
|
@davidrohr @shahor02 there are conflict in |
|
@afurs : ok, never mind, that happens now since multiple detectors have to edit the same file. If the fullCI succeeds I'll resolve the conflict manually and merge it. Otherwise you'll have to resolve and push a new commit. |
|
CI had passed, just merged the conflict with prior change in TPC part of FST, merging |
3 participants
No description provided.